Better "unexpected kw" handling in ternary parsing #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfitzseb
force-pushed
the
sp/ternary-unexpected-kw
branch
2 times, most recently
from
2915bd9 to
424be21
Compare
pfitzseb
force-pushed
the
sp/ternary-unexpected-kw
branch
from
424be21 to
15c028c
Compare
pfitzseb
force-pushed
the
sp/ternary-unexpected-kw
branch
from
c883efa to
7b6ad27
Compare
KristofferC
reviewed
Aug 31, 2022
Co-authored-by: Kristoffer Carlsson <[email protected]>
c42f
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
I think this is fine, as far as it goes.
I've been procrastinating about doing this review because I want to do error reporting more like I've vaguely outlined in #93.
But to motivate a general system like #93 we do need a bunch of specific use cases like this, #92 and all the other specific error messages which are hardcoded in various places.
So as long as error recovery is clearly marked and doesn't cause large scale disruption of the parser I think we can add it piecemeal for now.
| end | ||
|
|
||
| # FIXME: This is a very specific case. Error recovery should be handled more | ||
| # generally elsewhere. |
There was a problem hiding this comment.
aha agreed! This is why I've been wondering what to do about this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.