Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some small type inference improvements to allow for some basic static compiling #491

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

KristofferC
Copy link
Member

Allows the example in #490 to compile (together with JuliaLang/julia#55047 (comment)).

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.08%. Comparing base (6532515) to head (bb8e65f).

Files Patch % Lines
src/parser.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
- Coverage   96.21%   96.08%   -0.13%     
==========================================
  Files          13       13              
  Lines        4171     4034     -137     
==========================================
- Hits         4013     3876     -137     
  Misses        158      158              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add a test case after the base PR is merged.

Copy link
Member

@c42f c42f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@KristofferC
Copy link
Member Author

Would be good to add a test case after the base PR is merged.

Yep

@KristofferC KristofferC merged commit 992dc07 into main Aug 9, 2024
36 of 38 checks passed
@KristofferC KristofferC deleted the kc/trim_jet branch August 9, 2024 20:06
fredrikekre pushed a commit that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants