Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve syntax diffing in General registry checker #216

Merged
merged 1 commit into from
Mar 11, 2023

Conversation

c42f
Copy link
Member

@c42f c42f commented Mar 10, 2023

Now produces much more readable logs of broken syntax such as

┌ Error: Parsers succeed but disagree
│   fpath = "/home/c42f/.julia/dev/JuliaSyntax/tools/pkgs/TropicalYao_0.1.5/src/reversible/LogLikeNumbers/instructs.jl"
│   reduced_chunks =
│    end
│    
│    #          ┌─────────────────────────────────────────────────
│    @i @inline function (:*=(identity))(x::Tropical, y::Tropical)
│        (x |> content) += (y |> content)
│    end
│    #─┘

This is on top of #215 - ignore the first commit.

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #216 (e91dc14) into main (442f3e4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #216   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files          15       15           
  Lines        3868     3868           
=======================================
  Hits         3726     3726           
  Misses        142      142           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@timholy
Copy link
Member

timholy commented Mar 10, 2023

You presumably mean it's on top of #215? (#150 is the corresponding issue).

I struggle a bit to comprehend

Parsers succeed but disagreeyntax/tools/check_all_packages.jl:65

It seems like a file/line number is being used as part of a grammatical construction?

@c42f
Copy link
Member Author

c42f commented Mar 10, 2023

It seems like a file/line number is being used as part of a grammatical construction?

Hehe oops. That was a copy+paste error from the terminal where the progress bar printing corrupted the other printing due to ^C'ing the Julia process earlier.

And yes, this is on top of #215 apparently my brain wasn't working when I wrote the description 😅

@c42f c42f force-pushed the c42f/improve-General-syntax-check branch from 57fc1cf to e91dc14 Compare March 11, 2023 10:43
@c42f c42f merged commit c4f1f6a into main Mar 11, 2023
@c42f c42f deleted the c42f/improve-General-syntax-check branch March 11, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants