Record fixity of call type in flags #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now record which precise call syntax was used out of the four options: * Prefix calls with parens * Prefix operator calls * Infix operator calls * Postfix operator calls This allows us to distinguish keyword arguments from assignment, fixing several bugs with = to kw conversion.
c42f
force-pushed
the
c42f/refactor-call-heads
branch
from
24c5840 to
0bb5ec7
Compare
pfitzseb
reviewed
Oct 14, 2022
src/parse_stream.jl
Outdated
Comment on lines
87
to
88
| is_prefix_op_call(head) && (str = str*"h") | ||
| is_suffix_op_call(head) && (str = str*"j") |
There was a problem hiding this comment.
We're not limited to one-char suffixes here, right? So -pre/-suf or -pre/-post would probably be the more obvious choices.
There was a problem hiding this comment.
Flags can be combined (eg raw and triple string), so I did limit it to one char suffixes on purpose.
Could be a good idea though to make these clearer. But if we do, let's do all the flags at once.
There was a problem hiding this comment.
Actually I'll do this now after all: These particular flags aren't combined with others so this will be clearer and the lack of consistency shouldn't be a big deal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now record which precise call syntax was used out of the four options:
This allows us to distinguish keyword arguments from assignment, fixing several bugs with = to kw conversion.
Fixes #113
Close #99