a few more 0.7 updates #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
approved these changes
Jul 6, 2018
src/IJulia.jl
Outdated
| @@ -273,7 +273,8 @@ push_postexecute_hook(f::Function) = push!(postexecute_hooks, f) | |||
| Remove a function `f()` from the list of functions to | |||
| execute after executing any notebook cell. | |||
| """ | |||
| pop_postexecute_hook(f::Function) = splice!(postexecute_hooks, findfirst(equalto(f), postexecute_hooks)) | |||
| pop_postexecute_hook(f::Function) = | |||
| splice!(postexecute_hooks, findlast(isequal(f), postexecute_hooks)) | |||
src/IJulia.jl
Outdated
| @@ -289,7 +290,8 @@ push_preexecute_hook(f::Function) = push!(preexecute_hooks, f) | |||
| Remove a function `f()` from the list of functions to | |||
| execute before executing any notebook cell. | |||
| """ | |||
| pop_preexecute_hook(f::Function) = splice!(preexecute_hooks, findfirst(equalto(f), preexecute_hooks)) | |||
| pop_preexecute_hook(f::Function) = | |||
| splice!(preexecute_hooks, findlast(isequal(f), preexecute_hooks)) | |||
There was a problem hiding this comment.
Doesn’t need it. If f isn’t found, whether findlast returns 0 or nothing splice! will throw.
There was a problem hiding this comment.
(But I guess it wouldn't hurt to make sure it throws the same exception on 0.6 and 0.7.)
src/IJulia.jl
Outdated
| @@ -306,7 +308,8 @@ push_posterror_hook(f::Function) = push!(posterror_hooks, f) | |||
| Remove a function `f()` from the list of functions to | |||
| execute after an error occurs when a notebook cell is evaluated. | |||
| """ | |||
| pop_posterror_hook(f::Function) = splice!(posterror_hooks, findfirst(equalto(f), posterror_hooks)) | |||
| pop_posterror_hook(f::Function) = | |||
| splice!(posterror_hooks, findlast(isequal(f), posterror_hooks)) | |||
|
Looks like the Travis failure is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuing #671