-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformat README and update development instructions #115
base: master
Are you sure you want to change the base?
Conversation
All content is the same, except for the new section about how to use development versions on Julia 1.11+.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
=======================================
Coverage 79.33% 79.33%
=======================================
Files 10 10
Lines 1916 1916
=======================================
Hits 1520 1520
Misses 396 396 ☔ View full report in Codecov by Sentry. |
more of an independent package. As such, to use a different version it's enough | ||
to just `dev` it explicitly: | ||
```julia-repl | ||
pkg> dev https://github.com/JuliaLang/Distributed.jl.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it just dev Distributed.jl
or is the issue that it is not registered in the registry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it's not registered:
(@v1.11) pkg> dev Distributed.jl
Updating registry at `~/.julia/registries/General.toml`
ERROR: The following package names could not be resolved:
* Distributed (8ba89e20-285c-5b6f-9357-94700520ee1b in manifest but not in project)
Can we register it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, would need to be something similar to JuliaRegistries/General#89713
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going off this checklist I've opened two PRs that should complete excision and make Distributed upgradeable:
@vchuravy Since you reviewed this PR - can you approve when ready? Would you prefer we require review for every PR? I feel comfortable for folks to merge small PRs more quickly. |
All content is the same, except for the new section about how to use development versions on Julia 1.11+.
Fixes #113.