Backport public support to release-3
#808
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-3 #808 +/- ##
=============================================
+ Coverage 81.92% 82.33% +0.40%
=============================================
Files 4 4
Lines 791 815 +24
=============================================
+ Hits 648 671 +23
- Misses 143 144 +1 ☔ View full report in Codecov by Sentry. |
|
The failure in 1.2 and older seems to be genuine (see https://github.com/JuliaLang/Compat.jl/actions/runs/6909455727/job/18800838907?pr=808#step:6:172). |
| symbols = _get_symbols(symbols_expr) | ||
| if VERSION >= v"1.11.0-DEV.469" |
There was a problem hiding this comment.
| symbols = _get_symbols(symbols_expr) | |
| if VERSION >= v"1.11.0-DEV.469" | |
| if VERSION >= v"1.11.0-DEV.469" | |
| symbols = _get_symbols(symbols_expr) |
This should fix it, as the old julia versions no longer traverse the faulty path via _get_symbols.
There was a problem hiding this comment.
I want to keep the parsing outside the version check so that folks get errors consistently on all versions.
With that change, @compat 1+1 == 2 would expand to nothing on old versions of Julia and throw on new versions of Julia.
I've tried to implement a fix that actually supports @var_str while still throwing on invalid inputs on all versions.
There was a problem hiding this comment.
Great! That sounds like a good idea :)
|
Gentle bump |
cc @lgoettgens