Make Dates a weakdep
#791
Merged
Make Dates a weakdep
#791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exploits that `Compat` only really needs `Dates` (to extend it) on Julia versions without weakdep support (i.e. before 1.9). So on newer Julia versions, no (unnecessary) dependence on `Dates` is introduced without loosing anything on older Julia versions. Should a post-1.9 feature of `Dates` (or any other stdlib, actually) be added to `Compat` in the future, the way to do so is probably via a package extension.
martinholters
force-pushed
the
mh/weak-dep-dates
branch
from
0a6c876 to
bb27794
Compare
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
=======================================
Coverage 91.92% 91.92%
=======================================
Files 2 2
Lines 260 260
=======================================
Hits 239 239
Misses 21 21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
oscardssmith
approved these changes
Feb 16, 2023
|
@oscardssmith unless anyone else objects, I'd suggest we merge this and then in #790 try to find a solution for |
|
sounds good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the little brother of #790.
It exploits that
Compatonly really needsDates(to extend it) on Julia versions without weakdep support (i.e. before 1.9). So on newer Julia versions, no (unnecessary) dependence onDatesis introduced without loosing anything on older Julia versions.Should a post-1.9 feature of
Dates(or any other stdlib, actually) be added toCompatin the future, the way to do so is probably via a package extension (as proposed in #790), cc @oscardssmith.