Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] add popat! #774

Merged
merged 3 commits into from
Jun 1, 2022
Merged

[3.x] add popat! #774

merged 3 commits into from
Jun 1, 2022

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented May 24, 2022

Later it will require backporting.

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #774 (e64e132) into release-3 (95ea27f) will increase coverage by 0.00%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           release-3     #774   +/-   ##
==========================================
  Coverage      79.68%   79.69%           
==========================================
  Files              4        4           
  Lines            704      714   +10     
==========================================
+ Hits             561      569    +8     
- Misses           143      145    +2     
Impacted Files Coverage Δ
src/Compat.jl 79.67% <80.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95ea27f...e64e132. Read the comment docs.

@martinholters
Copy link
Member

It does not make much sense to put this on master, as the popat! has been added in Julia 1.5 and Compat master requires Julia 1.6 now. But I'm fine with directly adding it to the release-3 branch. Let me try to change the PR accordingly...

@martinholters martinholters changed the base branch from master to release-3 June 1, 2022 06:51
@martinholters martinholters changed the title add popat! [3.x] add popat! Jun 1, 2022
@martinholters
Copy link
Member

Took the liberty to rebase the branch accordingly and fix the README a bit, please double-check.

@bkamins
Copy link
Member Author

bkamins commented Jun 1, 2022

It does not make much sense to put this on master, as the popat! has been added in Julia 1.5 and Compat master requires Julia 1.6 now.

Right - makes sense.

Thank you for rebasing - all looks good.

Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkamins
Copy link
Member Author

bkamins commented Jun 1, 2022

@nalimilan - OK to merge and make a release?

@nalimilan nalimilan merged commit 952300c into JuliaLang:release-3 Jun 1, 2022
@nalimilan
Copy link
Member

@martinholters Can we just tag a 3.45.0?

@bkamins bkamins deleted the patch-1 branch June 1, 2022 17:03
@martinholters
Copy link
Member

@martinholters Can we just tag a 3.45.0?

Sure, that was the idea of bumping the version in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants