-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] add popat! #774
[3.x] add popat! #774
Conversation
Codecov Report
@@ Coverage Diff @@
## release-3 #774 +/- ##
==========================================
Coverage 79.68% 79.69%
==========================================
Files 4 4
Lines 704 714 +10
==========================================
+ Hits 561 569 +8
- Misses 143 145 +2
Continue to review full report at Codecov.
|
It does not make much sense to put this on master, as the |
Took the liberty to rebase the branch accordingly and fix the README a bit, please double-check. |
Right - makes sense. Thank you for rebasing - all looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nalimilan - OK to merge and make a release? |
@martinholters Can we just tag a 3.45.0? |
Sure, that was the idea of bumping the version in this PR. |
Later it will require backporting.