add ismutable to Compat for Julia PR 34652
#686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
martinholters
requested changes
Feb 5, 2020
There was a problem hiding this comment.
Some minor remarks, the addition itself looks good to me. But in any case, we should wait until JuliaLang/julia#34652 has landed with merging this one.
| # https://github.com/JuliaLang/julia/pull/34652 | ||
| if VERSION < v"1.5.0-DEV.231" | ||
| export ismutable | ||
| ismutable(@nospecialize(x)) = (Base.@_pure_meta; typeof(x).mutable) |
There was a problem hiding this comment.
This could use @pure (no bootstrapping issues in Compat.jl), but doesn't really matter.
martinholters
approved these changes
Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to add
ismutablefor julia PR JuliaLang/julia#34652