Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only #662

Merged
merged 7 commits into from
Sep 30, 2019
Merged

only #662

merged 7 commits into from
Sep 30, 2019

Conversation

mcabbott
Copy link
Contributor

@mcabbott mcabbott commented Sep 29, 2019 •
edited
Loading

Adds the function only with this version:

$ contrib/commit-name.sh ed3aefe42ce058192b39777c713cb5ff93830632
1.4.0-DEV.142

Edit: red X is from a failure at “Installing Julia…” for “Environment: julia_version=latest; Platform: x86”. Not my fault, surely.

martinholters
martinholters approved these changes Sep 29, 2019
View reviewed changes
Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We may want to enable the problematic test on later versions, but I don't think that's too important.

test/runtests.jl Outdated Show resolved Hide resolved
@martinholters
Copy link
Member

Hm, looks like merging master didn't go smoothly here.

@mcabbott
Copy link
Contributor Author

Sorry about that, should be fixed now, and also the links.

@martinholters martinholters merged commit ee4f41f into JuliaLang:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinholters martinholters martinholters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcabbott @martinholters