Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod(n, range) #661

Merged
merged 4 commits into from
Sep 29, 2019
Merged

mod(n, range) #661

merged 4 commits into from
Sep 29, 2019

Conversation

mcabbott
Copy link
Contributor

There are lots of recent small additions to Julia I’d like to be able to use on 1.2. Tell me if I’m doing this right, and then I’ll do a few more?

Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the version bound where I'm not sure why you got something else.

src/Compat.jl Outdated Show resolved Hide resolved
@martinholters martinholters merged commit 33b906f into JuliaLang:master Sep 29, 2019
@martinholters
Copy link
Member

Thanks for the contribution!

The list of links at the end of the README needs to be updated, but we can do that in a seperate PR. Just shouldn't forget before tagging.

@mcabbott mcabbott deleted the mod branch September 29, 2019 13:41
@mcabbott
Copy link
Contributor Author

mcabbott commented Sep 29, 2019

Ah, I didn’t scroll down that far, sorry. (Now fixed.)

I find the Readme pretty confusing BTW, wasn’t sure whether to add at the top or bottom, apologies if I made it worse. I guess #652 will help a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants