Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hasfield and hasproperty #650

Merged
merged 3 commits into from
Feb 8, 2019
Merged

Add hasfield and hasproperty #650

merged 3 commits into from
Feb 8, 2019

Conversation

tkf
Copy link
Member

@tkf tkf commented Feb 5, 2019

This PR backports hasfield and hasproperty introduced JuliaLang/julia#30496 for fixing JuliaLang/julia#28850.

@tkf tkf mentioned this pull request Feb 5, 2019
Open
5 tasks
@martinholters
Copy link
Member

Could hasproperty just return false on Julia 0.6?

@tkf
Copy link
Member Author

tkf commented Feb 6, 2019

Isn't it strange to define hasproperty when there is no setproperty! or getproperty? In 0.6-compatible code, I think it's better to stick with getfield/setfield!/hasfield.

martinholters
martinholters reviewed Feb 8, 2019
View reviewed changes
src/Compat.jl Outdated Show resolved Hide resolved
@martinholters martinholters merged commit 84c170f into JuliaLang:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinholters martinholters martinholters left review comments

@stevengj stevengj stevengj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkf @martinholters @stevengj