Remove old deprecations, deprecate obsolete stuff #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinholters
force-pushed
the
mh/deprecations
branch
from
461acbc to
dc73ae6
Compare
martinholters
force-pushed
the
mh/deprecations
branch
from
a0e670f to
80afcef
Compare
|
I guess we should wait a bit (a week or so?) whether v1.5.1 shows any more problems that need fixing, then merge this, heading towards v2.0. Objections? |
fredrikekre
approved these changes
Feb 1, 2019
ararslan
approved these changes
Feb 1, 2019
This was referenced Feb 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #640, which was the motivation to do this: When doing a breaking change, why not do all pending ones at once (in anticipation of the required major version bump).
Note that the removed tests passed with the deprecations in place (i.e. run against
666460fdc73ae680afcef).