Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update deprecated array constructor #421

Merged
merged 1 commit into from
Nov 30, 2017
Merged

update deprecated array constructor #421

merged 1 commit into from
Nov 30, 2017

Conversation

fredrikekre
Copy link
Member

These where introduced in #419 but just got deprecated on master (JuliaLang/julia#24781)

@fredrikekre
Copy link
Member Author

Actually, this changes what was intended to test #330 so we should just upper bound the test here instead I think and revert the change in #419. Does that make sense @Sacha0 ?

@fredrikekre fredrikekre mentioned this pull request Nov 30, 2017
Merged
@Sacha0
Copy link
Member

Sacha0 commented Nov 30, 2017

Actually, this changes what was intended to test #330 so we should just upper bound the test here instead I think and revert the change in #419. Does that make sense @Sacha0?

Yes, that proposal makes sense on this end :).

Sacha0
Sacha0 approved these changes Nov 30, 2017
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fredrikekre! :)

@fredrikekre fredrikekre merged commit 4aaff07 into master Nov 30, 2017
@fredrikekre fredrikekre deleted the fe/arrayconstr branch November 30, 2017 19:04
ararslan added a commit that referenced this pull request Dec 1, 2017
@ararslan
Revert "revert part of #419 and put tests in a version check instead (#…
3821799 
…421)"

This reverts commit 4aaff07.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sacha0 Sacha0 Sacha0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrikekre @Sacha0