Updates for retry changes in 0.6. #368
Conversation
|
Looks like the kwargs support to retry won't work on 0.4. Would it make sense to drop support for 0.4 now that we're moving on to 0.7? |
|
now's about the right time for that, yes |
|
I'm guessing that should be a separate PR which removes any 0.4 specific code? |
|
yeah, and deprecations that I know @timholy was wanting to get rid of or adjust (hopefully the consumers of them have moved on to not using them from Compat any more...) |
|
Should be good to review now that 0.4 has been dropped. |
|
Needs a README mention |
|
Bump. Needs conflicts resolved then should be good to go. |
rofinn
force-pushed
the
retry
branch
2 times, most recently
from
aeb74c6 to
de1f0b6
Compare
|
Should be good to go now. |
README.md
Outdated
| @@ -155,11 +155,12 @@ Currently, the `@compat` macro supports the following syntaxes: | |||
|
|
|||
| * `logdet` for `Number`s ([#22629]). | |||
|
|
|||
| * `fieldcount` is equivalent to `nfields` for Julia versions 0.6 and below and is used to | |||
| determine the number of fields in a data type ([#22350]). | |||
| * `fieldcount` is equivalent to `nfields` for Julia versions 0.6 and below and is used to determine the number of fields in a data type ([#22350]). | |||
There was a problem hiding this comment.
Yeah, it's just a new line change I accidentally introduced as part of resolving conflicts... didn't think it was a big issue.
There was a problem hiding this comment.
would be best not to touch this as it would be misleading in blame of the readme
|
Bump? |
I keep including the same retry version check in my code, so I figured this made more sense.