Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop v0.3 support #279

Merged
merged 11 commits into from
Sep 6, 2016
Merged

Drop v0.3 support #279

merged 11 commits into from
Sep 6, 2016

Conversation

TotalVerb
Copy link
Contributor

I have intentionally avoided touching the tests in this PR, so that it is more certain that nothing has regressed. Tests that are testing functionality in Base can be removed in a later PR.

Closes #277 by addressing it directly.

Also closes the following issues on account of the issues becoming obsolete, as they request a feature or bugfix in Base as of v0.4.0 release:

Also closes the following PRs on account of the added functionality being present in Base as of the v0.4.0 release:

@tkelman
Copy link
Contributor

tkelman commented Sep 5, 2016

I don't see why it's useful to delete all the code.

@andreasnoack
Copy link
Member

Less code to keep track of and lower risk of clashes between old and new definitions. Why would like to keep it if we drop support for 0.3?

@stevengj
Copy link
Member

stevengj commented Sep 5, 2016

I think the argument is that it is will be harder and harder to maintain 0.3 compatibility going forward as we add new 0.6 features. And once we drop 0.3 support for new features, we might as well delete the corresponding code for old features (since 0.3 users can still use the older Compat versions).

@tkelman
Copy link
Contributor

tkelman commented Sep 5, 2016

I disagree that deleting the code is worthwhile. It may be necessary to backport something to an 0.3-supporting branch, in which case it's better to have the code diverge less.

@TotalVerb
Copy link
Contributor Author

The code deletion is not urgent and can be discussed at a later time. I'll rebase it out of this PR.

@TotalVerb
Copy link
Contributor Author

All the code deletions have been reverted now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants