Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add join, escape_string, and unescape_string #273

Merged
merged 1 commit into from
Aug 20, 2016
Merged

Add join, escape_string, and unescape_string #273

merged 1 commit into from
Aug 20, 2016

Conversation

TotalVerb
Copy link
Contributor

@tkelman
Copy link
Contributor

tkelman commented Aug 19, 2016

LGTM, thanks

@@ -203,6 +203,8 @@ Currently, the `@compat` macro supports the following syntaxes:

* `fieldoffsets` has been deprecated in favor of `fieldoffset`[#14777](https://github.com/JuliaLang/julia/pull/14777).

* `print_escaped` is now another method on `escape_string`, `print_unescaped` a method on `unescape_string`, and `print_joined` a method on `join`. [#16603](https://github.com/JuliaLang/julia/pull/16603)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/method on/method of/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@musm
Copy link
Contributor

musm commented Aug 19, 2016

thanks!

@stevengj stevengj merged commit 188de7a into JuliaLang:master Aug 20, 2016
@musm
Copy link
Contributor

musm commented Aug 20, 2016

tag?

@TotalVerb
Copy link
Contributor Author

@musm Sure, see JuliaLang/METADATA.jl#6054.

dpsanders pushed a commit to dpsanders/Compat.jl that referenced this pull request Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants