Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Julia <1.7 compatibility. #154

Merged
merged 2 commits into from
Mar 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 16 additions & 47 deletions .buildkite/pipeline.yml
Original file line number Diff line number Diff line change
@@ -1,56 +1,25 @@
steps:

- label: "Julia 1.6"
- label: "Julia {{matrix.julia}}"
plugins:
- JuliaCI/julia#v1:
version: 1.6
- JuliaCI/julia-test#v1: ~
agents:
queue: "juliaecosystem"
os: "linux"
arch: "x86_64"
timeout_in_minutes: 15

- label: "Julia 1.7"
plugins:
- JuliaCI/julia#v1:
version: 1.7
- JuliaCI/julia-test#v1: ~
agents:
queue: "juliaecosystem"
os: "linux"
arch: "x86_64"
timeout_in_minutes: 15

- label: "Julia 1.8"
plugins:
- JuliaCI/julia#v1:
version: 1.8
- JuliaCI/julia-test#v1: ~
agents:
queue: "juliaecosystem"
os: "linux"
arch: "x86_64"
timeout_in_minutes: 15

- label: "Julia 1.9"
plugins:
- JuliaCI/julia#v1:
version: 1.9
- JuliaCI/julia-test#v1: ~
agents:
queue: "juliaecosystem"
os: "linux"
arch: "x86_64"
timeout_in_minutes: 15

- label: "Julia nightly"
plugins:
- JuliaCI/julia#v1:
version: nightly
version: "{{matrix.julia}}"
- JuliaCI/julia-test#v1: ~
agents:
queue: "juliaecosystem"
os: "linux"
arch: "x86_64"
timeout_in_minutes: 15
matrix:
setup:
julia:
- "1.6"
- "1.7"
- "1.8"
- "1.9"
- "1.10"
- "1.11"
- "nightly"
adjustments:
- with:
julia: "nightly"
soft_fail: true
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "BugReporting"
uuid = "bcf9a6e7-4020-453c-b88e-690564246bb8"
authors = ["Keno Fischer <[email protected]>", "Tim Besard <[email protected]>"]
version = "0.3.4"
version = "0.3.5"

[deps]
Downloads = "f43a241f-c20a-4ad4-852c-f6b1247861c6"
Expand Down
12 changes: 10 additions & 2 deletions src/BugReporting.jl
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,11 @@ include("sync_compat.jl")
function get_upload_params()
# big disclaimer
println()
printstyled("### IMPORTANT =============================================================\n", blink = true)
if VERSION >= v"1.7"
printstyled("### IMPORTANT =============================================================\n", blink = true)
else
println("### IMPORTANT =============================================================")
end
println("""
You are about to upload a trace directory to a publicly accessible location.
Such traces contain any information that was accessed by the traced
Expand All @@ -584,7 +588,11 @@ function get_upload_params()
DO NOT proceed, if you do not wish to make this information publicly available.
By proceeding you explicitly agree to waive any privacy interest in the
uploaded information.""")
printstyled("### =======================================================================\n", blink = true)
if VERSION >= v"1.7"
printstyled("### =======================================================================\n", blink = true)
else
println("### =======================================================================")
end
println()

c = Channel()
Expand Down