Skip to content

Commit

Permalink
Fix Julia <1.7 compatibility. (#154)
Browse files Browse the repository at this point in the history
  • Loading branch information
maleadt authored Mar 16, 2024
1 parent 85b9dee commit 88ef063
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 50 deletions.
63 changes: 16 additions & 47 deletions .buildkite/pipeline.yml
Original file line number Diff line number Diff line change
@@ -1,56 +1,25 @@
steps:

- label: "Julia 1.6"
- label: "Julia {{matrix.julia}}"
plugins:
- JuliaCI/julia#v1:
version: 1.6
- JuliaCI/julia-test#v1: ~
agents:
queue: "juliaecosystem"
os: "linux"
arch: "x86_64"
timeout_in_minutes: 15

- label: "Julia 1.7"
plugins:
- JuliaCI/julia#v1:
version: 1.7
- JuliaCI/julia-test#v1: ~
agents:
queue: "juliaecosystem"
os: "linux"
arch: "x86_64"
timeout_in_minutes: 15

- label: "Julia 1.8"
plugins:
- JuliaCI/julia#v1:
version: 1.8
- JuliaCI/julia-test#v1: ~
agents:
queue: "juliaecosystem"
os: "linux"
arch: "x86_64"
timeout_in_minutes: 15

- label: "Julia 1.9"
plugins:
- JuliaCI/julia#v1:
version: 1.9
- JuliaCI/julia-test#v1: ~
agents:
queue: "juliaecosystem"
os: "linux"
arch: "x86_64"
timeout_in_minutes: 15

- label: "Julia nightly"
plugins:
- JuliaCI/julia#v1:
version: nightly
version: "{{matrix.julia}}"
- JuliaCI/julia-test#v1: ~
agents:
queue: "juliaecosystem"
os: "linux"
arch: "x86_64"
timeout_in_minutes: 15
matrix:
setup:
julia:
- "1.6"
- "1.7"
- "1.8"
- "1.9"
- "1.10"
- "1.11"
- "nightly"
adjustments:
- with:
julia: "nightly"
soft_fail: true
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "BugReporting"
uuid = "bcf9a6e7-4020-453c-b88e-690564246bb8"
authors = ["Keno Fischer <[email protected]>", "Tim Besard <[email protected]>"]
version = "0.3.4"
version = "0.3.5"

[deps]
Downloads = "f43a241f-c20a-4ad4-852c-f6b1247861c6"
Expand Down
12 changes: 10 additions & 2 deletions src/BugReporting.jl
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,11 @@ include("sync_compat.jl")
function get_upload_params()
# big disclaimer
println()
printstyled("### IMPORTANT =============================================================\n", blink = true)
if VERSION >= v"1.7"
printstyled("### IMPORTANT =============================================================\n", blink = true)
else
println("### IMPORTANT =============================================================")
end
println("""
You are about to upload a trace directory to a publicly accessible location.
Such traces contain any information that was accessed by the traced
Expand All @@ -584,7 +588,11 @@ function get_upload_params()
DO NOT proceed, if you do not wish to make this information publicly available.
By proceeding you explicitly agree to waive any privacy interest in the
uploaded information.""")
printstyled("### =======================================================================\n", blink = true)
if VERSION >= v"1.7"
printstyled("### =======================================================================\n", blink = true)
else
println("### =======================================================================")
end
println()

c = Channel()
Expand Down

2 comments on commit 88ef063

@maleadt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/103019

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.3.5 -m "<description of version>" 88ef063c0df5e1ae3018147ffc962ec0163b485a
git push origin v0.3.5

Please sign in to comment.