Rename AllocInstance to AllocationSite and de-duplicate by source info
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topolarity
changed the title
AllocInstance to AllocSite and de-duplicate by source infoAllocInstance to AllocationSite and de-duplicate by source info
topolarity
force-pushed
the
ct/dedup-alloc-site
branch
4 times, most recently
from
958661d to
41346b5
Compare
topolarity
commented
Oct 16, 2023
Loop unrolling and similar optimizations can cause allocations to be
duplicated to multiple locations in the LLVM IR despite corresponding to
a single allocation in the Julia IR.
After this change `check_allocs(*, (Matrix{Float64},Matrix{Float64}))`
reports 9 allocations instead of 21.
topolarity
force-pushed
the
ct/dedup-alloc-site
branch
2 times, most recently
from
d324f7d to
4688a92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7
Loop unrolling and similar optimizations can cause allocations to be duplicated to multiple locations in the LLVM IR despite corresponding to a single allocation in the Julia IR.
After this change
check_allocs(*, (Matrix{Float64},Matrix{Float64}))reports 14 allocations instead of 20.