Add warning to check_allocs(...)
#49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is useful for investigation and optimization, but we don't have sufficient parity/stability guarantees from the Julia compiler to use it for allocation-free guarantees at runtime. This adds a note to clarify that such a usage is _unsound_.
Open
topolarity
force-pushed
the
ct/add-warning
branch
from
dc0d6ac
to
875e3ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The results from
check_allocs(foo, (...))cannot strictly be expected to apply across Julia invocations or across any new method definitions (i.e. worlds). Furthermore, we don't have yet have sufficient testing to guarantee that our optimization pipeline in GPUCompiler will never diverge (however slightly) from the base Julia pipeline.The unfortunate result is that we don't have the parity/stability guarantees we need from the Julia compiler to use
check_allocs(foo, ...)for allocation-free guarantees at runtime.This adds a note to clarify that such a usage is unsound.