Change allocation function logic to be negative. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topolarity
reviewed
Oct 2, 2023
topolarity
reviewed
Oct 3, 2023
Merged
topolarity
reviewed
Oct 4, 2023
gbaraldi
force-pushed
the
gb/negative-logic
branch
from
9c32837
to
78f50e3
Compare
topolarity
reviewed
Oct 11, 2023
topolarity
reviewed
Oct 11, 2023
topolarity
reviewed
Oct 11, 2023
topolarity
reviewed
Oct 11, 2023
topolarity
approved these changes
Oct 11, 2023
topolarity
reviewed
Oct 12, 2023
| const known_alloc_with_throw_funcs = ( | ||
| "jl_f_ifelse", "ijl_f_ifelse", | ||
| "jl_f_typeassert", "ijl_f_typeassert", | ||
| "jl_f_is", "ijl_f_is", |
There was a problem hiding this comment.
Wait, isn't jl_f_is non-allocating? jl_egal is
I don't think jl_f_throw or jl_throw are technically allocating either
There was a problem hiding this comment.
I think it's also possible for us to call jl_typeassert directly
topolarity
reviewed
Oct 12, 2023
| "jl_enter_handler", "ijl_enter_handler", | ||
| "jl_pop_handler", "ijl_pop_handler", | ||
| "jl_f_typeof", "ijl_f_typeof", | ||
| ) |
There was a problem hiding this comment.
jl_array_data_owner and jl_object_id should be in this list too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes logic to be safer, where only functions that are known not to allocate are allowed.