Merge pull request #27 from JuliaComputing/ct/ignore_throw_by_default

Make `ignore_throw=true` the default
JuliaLang · Oct 30, 2023 · fbb888b · fbb888b
2 parents d21c712 + d247e55
commit fbb888b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/AllocCheck.jl b/src/AllocCheck.jl
@@ -257,7 +257,7 @@ AllocCheck.AllocInstance[]
 ```
 
 """
-function check_allocs(@nospecialize(func), @nospecialize(types); entry_abi=:specfunc, ret_mod=false, ignore_throw=false)
+function check_allocs(@nospecialize(func), @nospecialize(types); entry_abi=:specfunc, ret_mod=false, ignore_throw=true)
     job = create_job(func, types; entry_abi)
     allocs = AllocInstance[]
     mod = JuliaContext() do ctx

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -17,18 +17,18 @@ function same_ccall()
 end
 
 @testset "AllocCheck.jl" begin
-    @test length(check_allocs(mod, (Float64,Float64))) == 0
+    @test length(check_allocs(mod, (Float64,Float64); ignore_throw=false)) == 0
     @test length(check_allocs(sin, (Float64,); ignore_throw=false)) > 0
     @test length(check_allocs(sin, (Float64,); ignore_throw=true)) == 0
-    @test length(check_allocs(*, (Matrix{Float64},Matrix{Float64}))) != 0
+    @test length(check_allocs(*, (Matrix{Float64},Matrix{Float64}); ignore_throw=true)) != 0
 
     @test length(check_allocs(alloc_in_catch, (); ignore_throw=false)) == 2
     @test length(check_allocs(alloc_in_catch, (); ignore_throw=true)) == 1
 
-    @test length(check_allocs(same_ccall, (), ignore_throw=false)) == 2
-    @test length(check_allocs(same_ccall, (), ignore_throw=true)) == 2
+    @test length(check_allocs(same_ccall, (); ignore_throw=false)) == 2
+    @test length(check_allocs(same_ccall, (); ignore_throw=true)) == 2
 
-    @test length(check_allocs(first, (Core.SimpleVector,); ignore_throw = false)) == 3
-    @test length(check_allocs(first, (Core.SimpleVector,); ignore_throw = true)) == 0
-    @test length(check_allocs(time, ())) == 0
+    @test length(check_allocs(first, (Core.SimpleVector,); ignore_throw=false)) == 3
+    @test length(check_allocs(first, (Core.SimpleVector,); ignore_throw=true)) == 0
+    @test length(check_allocs(time, (); ignore_throw=false)) == 0
 end