Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bisection root-finder #262

Closed
wants to merge 10 commits into from
Closed

Add bisection root-finder #262

wants to merge 10 commits into from

Conversation

dpsanders
Copy link
Member

@dpsanders dpsanders commented Mar 19, 2017

Fixes #204.

This adds a bisection root finder that works with single or multiple variables.

Currently, this involves modifying the Root type.
For bisection in particular, this is, in some sense, not necessary, since it cannot prove uniqueness, so any roots are :unknown.

However, for multi-dimensional root finding in general, it is maybe necessary to do so.

@coveralls
Copy link

coveralls commented Mar 19, 2017

Coverage Status

Coverage decreased (-1.07%) to 89.194% when pulling cedefba on bisection into 1c0b48f on master.

@codecov-io
Copy link

codecov-io commented Mar 19, 2017

Codecov Report

Merging #262 into master will decrease coverage by 1.31%.
The diff coverage is 52.38%.

@@           Coverage Diff            @@
##           master   #262      +/-   ##
========================================
- Coverage   90.31%    89%   -1.32%     
========================================
  Files          26     27       +1     
  Lines        1084   1100      +16     
========================================
  Hits          979    979              
- Misses        105    121      +16
Impacted Files Coverage Δ
src/root_finding/bisection.jl 0% <0%> (ø)
src/root_finding/newton.jl 80.7% <100%> (-10.53%) ⬇️
src/root_finding/root_finding.jl 86.79% <100%> (+1.68%) ⬆️
src/root_finding/krawczyk.jl 95.45% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac8d0a8...e42821e. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.07%) to 89.194% when pulling cedefba on bisection into 1c0b48f on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.07%) to 89.194% when pulling cedefba on bisection into 1c0b48f on master.

@coveralls
Copy link

coveralls commented Mar 19, 2017

Coverage Status

Coverage decreased (-1.07%) to 89.194% when pulling 71d24b4 on bisection into 1c0b48f on master.

@dpsanders dpsanders changed the title Add simple 1D bisection root-finder Add bisection root-finder Mar 19, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 89.0% when pulling e42821e on bisection into ac8d0a8 on master.

@dpsanders
Copy link
Member Author

This is ready. Any objection to merging, @lbenet ?

@dpsanders
Copy link
Member Author

@dpsanders dpsanders closed this May 4, 2017
@OlivierHnt OlivierHnt deleted the bisection branch December 9, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants