-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bisection root-finder #262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
========================================
- Coverage 90.31% 89% -1.32%
========================================
Files 26 27 +1
Lines 1084 1100 +16
========================================
Hits 979 979
- Misses 105 121 +16
Continue to review full report at Codecov.
|
1 similar comment
dpsanders
changed the title
Add simple 1D bisection root-finder
Add bisection root-finder
Mar 19, 2017
This is ready. Any objection to merging, @lbenet ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #204.
This adds a
bisection
root finder that works with single or multiple variables.Currently, this involves modifying the
Root
type.For bisection in particular, this is, in some sense, not necessary, since it cannot prove uniqueness, so any roots are
:unknown
.However, for multi-dimensional root finding in general, it is maybe necessary to do so.