Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trig functions for large arguments #260

Merged
merged 4 commits into from
Mar 20, 2017
Merged

Fix trig functions for large arguments #260

merged 4 commits into from
Mar 20, 2017

Conversation

dpsanders
Copy link
Member

@dpsanders dpsanders commented Mar 18, 2017

Fixes #239.

@coveralls
Copy link

coveralls commented Mar 19, 2017

Coverage Status

Coverage remained the same at 90.269% when pulling d600820 on fix_trig_large_args into 1c0b48f on master.

@codecov-io
Copy link

codecov-io commented Mar 19, 2017

Codecov Report

Merging #260 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #260   +/-   ##
=======================================
  Coverage   90.26%   90.26%           
=======================================
  Files          26       26           
  Lines        1079     1079           
=======================================
  Hits          974      974           
  Misses        105      105
Impacted Files Coverage Δ
src/intervals/trigonometric.jl 99.09% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0b48f...d600820. Read the comment docs.

@dpsanders
Copy link
Member Author

This is ready. Are you happy for me to merge, @lbenet ?

@lbenet lbenet merged commit ba302f5 into master Mar 20, 2017
@lbenet
Copy link
Member

lbenet commented Mar 20, 2017

Nice solution! I'm merging

@OlivierHnt OlivierHnt deleted the fix_trig_large_args branch December 9, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants