-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds automatic display of bechmark results #90
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
name: Run benchmarks | ||
|
||
on: | ||
pull_request: | ||
types: [labeled, opened, synchronize, reopened] | ||
|
||
# Only trigger the benchmark job when you add `run benchmark` label to the PR | ||
jobs: | ||
Benchmark: | ||
runs-on: ubuntu-latest | ||
if: contains(github.event.pull_request.labels.*.name, 'run benchmark') | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: julia-actions/setup-julia@latest | ||
with: | ||
version: 1.4 | ||
- name: Install dependencies | ||
run: julia -e 'using Pkg; pkg"add PkgBenchmark [email protected]"' | ||
- name: Run benchmarks | ||
run: julia -e 'using BenchmarkCI; BenchmarkCI.judge()' | ||
- name: Post results | ||
run: julia -e 'using BenchmarkCI; BenchmarkCI.postjudge()' | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
- name: Push results | ||
run: julia -e "using BenchmarkCI; BenchmarkCI.pushresult()" | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,3 +4,5 @@ | |
.DS_Store | ||
docs/build/ | ||
docs/site/ | ||
/.benchmarkci | ||
/benchmark/*.json | ||
Comment on lines
+7
to
+8
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are these files appearing? How are they generated? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Locally these files appear for me. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
[deps] | ||
BenchmarkTools = "6e4b80f9-dd63-53aa-95a3-0cdb28fa8baf" | ||
PkgBenchmark = "32113eaa-f34f-5b0d-bd6c-c81e245fc73d" | ||
TaylorModels = "314ce334-5f6e-57ae-acf6-00b6e903104a" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you show/describe how this works? It seems to me from these lines that you need to add
run benchmark
somewhere to see this working.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BenchmarkCI crates
Benchmark-result
branch and saves results there.For example look at this PR, github-actions bot comments the results there, and saves them in
Benchmark-result
branch here (In this repositories case we need not mentionrun benchmark
explicitly)There are many ways one can trigger Benchmarking. In our case when some one adds
run benchmark
label to the comment of PR. We can also have configuration that trigger benchmarking for each PR without mentioning it explicitly.