Update for 1.0 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies, apparently I never saw this. Many thanks! |
|
No problem, I think I filed several issues/PRs etc all around the same time and it probably got lost in the mix :). If I remember right, this was just a start to updating the repo since the tests hung and there was a failure still. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires JuliaIntervals/IntervalRootFinding.jl#139 (or equivalent) to be merged and a patch release made in order to have a resolvable set of versions. I think we need IntervalArithmetic 0.16 because we need the patch for fixing escaping inDone!@roundfor the definitions here to work, so we need a version of IntervalRootFinding compatible with that.This updates the syntax for calling
root, adds a Project.toml etc. I also copied the updated appveyor configuration from IntervalRootFinding.jl. Locally (using IntervalRootFinding#139), one of the tests here fails, with the errorwhich look like differences in rounding or something. I figured I would let someone else decide what they write answer is for that. After that failure, the tests seem to hang; I think some of the root finding problems are very slow. Maybe the tolerances need to be tweaked, or a different contractor used?