Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export interval definition for convenience #176

Merged
merged 5 commits into from
Aug 5, 2021

Conversation

Datseris
Copy link
Contributor

@Datseris Datseris commented Aug 4, 2021

No description provided.

@lucaferranti
Copy link
Member

did you know about ValidatedNumerics.jl which exports all (well almost) julia intervals packages at once?

Nevertheless, I see no harm in this PR, as someone may just want to use IntervalRootFinding without e.g. ICP and TaylorModels.

Just one commment, why not using @reexport IntervalArithmetic instead of just re-exporting the ..?

@lucaferranti lucaferranti linked an issue Aug 5, 2021 that may be closed by this pull request
@Datseris
Copy link
Contributor Author

Datseris commented Aug 5, 2021

I didn't know of validatedNumerics.jl, but I do not think that would be a viable option for my case (which adds a package as a dependency to some other package), as one needs to minimize dependencies.

Sure @reexport IntervalArithmetic is better, I'll do that one.

@Datseris
Copy link
Contributor Author

Datseris commented Aug 5, 2021

That is a good idea, yes. We just have to make sure that there is no problem if you also explicitly import IntervalArithmetic.jl.

Yes this is totally fine, I've already tested it in DynamicalSystems.jl. Julia understands that the .. that this package exports does come from IntervalArithemtic.jl and there will be no conflicts even if you import it.

@Datseris
Copy link
Contributor Author

Datseris commented Aug 5, 2021

This is good to go I think.

@lucaferranti lucaferranti self-requested a review August 5, 2021 16:35
@lucaferranti
Copy link
Member

LGTM, thanks!

@lucaferranti lucaferranti merged commit f0014e4 into JuliaIntervals:master Aug 5, 2021
@lucaferranti
Copy link
Member

@Datseris the new release should now be available in the Julia registry.

@Datseris Datseris deleted the patch-1 branch August 5, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export interval type
2 participants