Make bisection test more expressive #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwater
force-pushed
the
dev_bisection_test
branch
from
db71201 to
cbf17b0
Compare
gwater
force-pushed
the
dev_bisection_test
branch
from
cbf17b0 to
6b090cf
Compare
dpsanders
approved these changes
Jun 26, 2020
test/roots.jl
Outdated
| @@ -55,14 +55,19 @@ newtonlike_methods = [Newton, Krawczyk] | |||
| end | |||
|
|
|||
|
|
|||
| in_solution_set(point, solution_intervals) = | |||
| any(map(interval -> point in interval, solution_intervals)) | |||
There was a problem hiding this comment.
I believe you remove the map and just write any(interval -> point in interval, solution_intervals), which should even be slightly more efficient.
There was a problem hiding this comment.
Yes, that's correct. I've adjusted the PR.
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see our discussion in #153 (comment)