-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid emptying all the minimisers if hitting minimum at the begining #63
Avoid emptying all the minimisers if hitting minimum at the begining #63
Conversation
Thanks! Could you add your example as a test case please? |
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
+ Coverage 91.91% 93.06% +1.15%
==========================================
Files 4 4
Lines 99 101 +2
==========================================
+ Hits 91 94 +3
+ Misses 8 7 -1
Continue to review full report at Codecov.
|
bump (?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies @Suavesito-Olimpiada for the veery long delay with this. It fell off my radar, although it is not of course a valid excuse. I think this PR looks good, could you still bump the patch version in the Project.toml, so we can release a new version with the bug fix? :)
1a9db4e
to
e579b60
Compare
@lucaferranti I bumped the version to |
fix #62