Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid emptying all the minimisers if hitting minimum at the begining #63

Merged

Conversation

Suavesito-Olimpiada
Copy link
Contributor

fix #62

@dpsanders
Copy link
Member

Thanks! Could you add your example as a test case please?

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2021

Codecov Report

Merging #63 (6a5a7b1) into master (9bddaed) will increase coverage by 1.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   91.91%   93.06%   +1.15%     
==========================================
  Files           4        4              
  Lines          99      101       +2     
==========================================
+ Hits           91       94       +3     
+ Misses          8        7       -1     
Impacted Files Coverage Δ
src/HeapedVectors.jl 98.07% <100.00%> (ø)
src/SortedVectors.jl 75.00% <100.00%> (+2.77%) ⬆️
src/optimise.jl 100.00% <0.00%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bddaed...6a5a7b1. Read the comment docs.

@Suavesito-Olimpiada
Copy link
Contributor Author

Test added based on the simpler case found in this comment from the issue #62.

@Suavesito-Olimpiada
Copy link
Contributor Author

bump (?)

Copy link
Member

@lucaferranti lucaferranti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies @Suavesito-Olimpiada for the veery long delay with this. It fell off my radar, although it is not of course a valid excuse. I think this PR looks good, could you still bump the patch version in the Project.toml, so we can release a new version with the bug fix? :)

@Suavesito-Olimpiada
Copy link
Contributor Author

@lucaferranti I bumped the version to v0.4.6, but there is a conflict to resolve.

@lucaferranti lucaferranti merged commit c7de3d4 into JuliaIntervals:master Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minimise error because not minimum found
4 participants