classify interval matrices #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With underscores it is more readable. In fact I would write |
Codecov Report
@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 89.68% 91.87% +2.19%
==========================================
Files 4 5 +1
Lines 126 160 +34
==========================================
+ Hits 113 147 +34
Misses 13 13
Continue to review full report at Codecov.
|
4 tasks
mforets
approved these changes
Jun 22, 2021
lucaferranti
force-pushed
the
lf/classify
branch
from
840bd6d to
7b3ebff
Compare
|
a conflict needs to be resolved before merging |
add test for strictly diagonal dominant matrices changed name for is_sdd_matrix and added test for Z-matrix added tests for M matrix fix typo in tests remove import automatically added by vscode small fixes small fixes don't use sum in sdd test added link to references in docstrings check inv(Ac)A is H-matrix in test for strongly regular matrix update is_strongly_regular docstring
lucaferranti
force-pushed
the
lf/classify
branch
from
a8480ea to
fb9e721
Compare
|
this can be merged now I think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functions to classify interval matrices
Regarding the names, better with or without underscore?