Add methods for IntervalBox previously in IntervalRootFinding #160

lbenet · 2018-06-19T15:19:17Z

Fixes #158

lbenet · 2018-06-19T15:20:09Z

See also JuliaIntervals/IntervalRootFinding.jl#78, which requires a new patch version.

lbenet · 2018-06-19T16:10:55Z

@dpsanders Question: Currently, mid(X) is equivalent to mid(X, 0.5); on the other hand, bisect(X) corresponds to bisect(X, 127/256), which was the way it was defined in IntervalRootFinding. Shall I leave it like that, or have the default value equal to 0.5, and change things in IntervalRootFinding?

Incidentally, tests are passing (except maybe for appveyor).

codecov-io · 2018-06-19T16:11:56Z

Codecov Report

Merging #160 into master will increase coverage by 0.2%.
The diff coverage is 80%.

@@            Coverage Diff            @@
##           master     #160     +/-   ##
=========================================
+ Coverage   91.95%   92.15%   +0.2%     
=========================================
  Files          22       23      +1     
  Lines        1044     1058     +14     
=========================================
+ Hits          960      975     +15     
+ Misses         84       83      -1

Impacted Files	Coverage Δ
src/IntervalArithmetic.jl	`100% <ø> (ø)`	⬆️
src/multidim/intervalbox.jl	`78.57% <0%> (-9.43%)`	⬇️
src/bisect.jl	`100% <100%> (ø)`
src/intervals/intervals.jl	`80.95% <100%> (+0.46%)`	⬆️
src/intervals/special.jl	`100% <100%> (+9.09%)`	⬆️
src/intervals/arithmetic.jl	`97.43% <0%> (+1.02%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f399c8...dc8db55. Read the comment docs.

lbenet · 2018-06-22T00:24:21Z

@dpsanders Should I go ahead and merge this?

dpsanders · 2018-06-22T20:36:08Z

The default for mid corresponds to that of the IEEE standard, so I guess we should leave it.
The default for bisect is more useful as being not equal to 0.5, since that avoids problems with zeros at 0 when using symmetric intervals, and generally seems more useful.

dpsanders · 2018-06-22T20:37:19Z

src/multidim/intervalbox.jl

@@ -45,7 +45,7 @@ Return a vector of the `mid` of each interval composing the `IntervalBox`.
 See `mid(X::Interval, α=0.5)` for more informations.
 """
 mid(X::IntervalBox) = mid.(X)
-mid(X::IntervalBox, α) = mid.(X, α)
+mid(X::IntervalBox, α) = mid.(X[:], α)


This can be left as mid.(X, alpha) after incorporating the change in #159

Shall I wait that #159 to change it, or should I leave it like this for the time being? (#161 has some difficulties related to this.)

dpsanders · 2018-06-22T20:40:14Z

src/multidim/intervalbox.jl

@@ -73,6 +73,12 @@ diam(X::IntervalBox) = maximum(diam.(X.v))

 emptyinterval(X::IntervalBox{N,T}) where {N,T} = IntervalBox(emptyinterval.(X.v))

+isinf(X::IntervalBox) = any(isinf.(X))


This can be written any(isinf, X), which I believe should be slightly faster.

dpsanders · 2018-06-22T20:41:18Z

src/multidim/intervalbox.jl

+
+isinterior(X::IntervalBox{N,T}, Y::IntervalBox{N,T}) where {N,T} = all(isinterior.(X, Y))
+
+contains_zero(X::SVector) = all(contains_zero.(X))


all(contains_zero, X)

dpsanders · 2018-06-22T20:41:25Z

src/multidim/intervalbox.jl

+isinterior(X::IntervalBox{N,T}, Y::IntervalBox{N,T}) where {N,T} = all(isinterior.(X, Y))
+
+contains_zero(X::SVector) = all(contains_zero.(X))
+contains_zero(X::IntervalBox) = all(contains_zero.(X))


dpsanders · 2018-06-22T20:41:42Z

test/interval_tests/complex.jl

@@ -14,7 +14,6 @@ end

 @testset "Complex functions" begin
    Z = (3 ± 1e-7) + (4 ± 1e-7)*im
-    @test sin(Z) == Interval(3.853734949309744, 3.8537411265295543) - Interval(27.016810169394066, 27.016816346613904)*im
-
+    @test sin(Z) == complex(sin(real(Z))*cosh(imag(Z)),sinh(imag(Z))*cos(real(Z)))


Thanks! I though this way is more stable :-)

dpsanders · 2018-06-22T20:42:13Z

LGTM, thanks! Feel free to incorporate #159 here.

lbenet · 2018-06-23T23:23:10Z

I've merged #159, rebased to current master, included a missing suggestion of your review. I'll wait for travis tests to pass, and then merge.

coveralls · 2018-06-23T23:57:19Z

Coverage increased (+0.2%) to 92.155% when pulling dc8db55 on lb/iss158 into 8f399c8 on master.

lbenet · 2018-06-24T01:23:26Z

Merged.

cvanaret · 2018-11-26T14:57:34Z

src/bisect.jl

@@ -0,0 +1,42 @@
+
+const where_bisect = 0.49609375


This looks like a magic constant :) 0.5 - 1/256, if I'm not mistaken. Is there a particular reason for that?

dpsanders · 2018-11-26T16:07:22Z

No particular reason, just something close to 0.5 but not exactly equal to 0.5.

lbenet · 2018-11-26T16:58:08Z

I think we needed something close to zero and to be exactly-representable floating point. Also, I think there were cases were rounding down had some sort of preference.

lbenet mentioned this pull request Jun 19, 2018

Add methods for IntervalBox that are used in IntervalRootFinding #158

Closed

lbenet mentioned this pull request Jun 22, 2018

Add hashing for Intervals #161

Merged

dpsanders reviewed Jun 22, 2018

View reviewed changes

lbenet mentioned this pull request Jun 23, 2018

Add another broadcast method for IntervalBox #159

Merged

Luis Benet added 3 commits June 23, 2018 18:17

Add methods for IntervalBox previously in IntervalRootFinding

7c0d6d4

Remove a reference to IntervalRootFinding, and fix complex interval test

b088bfd

Implement suggestions of the review

53f075a

lbenet force-pushed the lb/iss158 branch from ec1162c to 53f075a Compare June 23, 2018 23:18

Incorporate a missing suggestion of the review

dc8db55

lbenet merged commit 37f126e into master Jun 24, 2018

lbenet mentioned this pull request Jun 24, 2018

Move general methods of IntervalBox to IntervalArithmetic JuliaIntervals/IntervalRootFinding.jl#83

Merged

lbenet deleted the lb/iss158 branch June 24, 2018 01:35

lbenet mentioned this pull request Jun 25, 2018

Broadcast in isinf and contains_zero, with tests #162

Merged

dpsanders mentioned this pull request Jul 19, 2018

Move bisect to this package #59

Closed

cvanaret reviewed Nov 26, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add methods for IntervalBox previously in IntervalRootFinding #160

Add methods for IntervalBox previously in IntervalRootFinding #160

lbenet commented Jun 19, 2018

lbenet commented Jun 19, 2018

lbenet commented Jun 19, 2018

codecov-io commented Jun 19, 2018 •

edited

Loading

lbenet commented Jun 22, 2018

dpsanders commented Jun 22, 2018

dpsanders Jun 22, 2018

lbenet Jun 22, 2018

dpsanders Jun 22, 2018

dpsanders Jun 22, 2018

dpsanders Jun 22, 2018

dpsanders Jun 22, 2018

lbenet Jun 22, 2018

dpsanders commented Jun 22, 2018

lbenet commented Jun 23, 2018

coveralls commented Jun 23, 2018 •

edited

Loading

lbenet commented Jun 24, 2018

cvanaret Nov 26, 2018

dpsanders commented Nov 26, 2018

lbenet commented Nov 26, 2018

		@@ -73,6 +73,12 @@ diam(X::IntervalBox) = maximum(diam.(X.v))

		emptyinterval(X::IntervalBox{N,T}) where {N,T} = IntervalBox(emptyinterval.(X.v))

		isinf(X::IntervalBox) = any(isinf.(X))


		isinterior(X::IntervalBox{N,T}, Y::IntervalBox{N,T}) where {N,T} = all(isinterior.(X, Y))

		contains_zero(X::SVector) = all(contains_zero.(X))

Add methods for IntervalBox previously in IntervalRootFinding #160

Add methods for IntervalBox previously in IntervalRootFinding #160

Conversation

lbenet commented Jun 19, 2018

lbenet commented Jun 19, 2018

lbenet commented Jun 19, 2018

codecov-io commented Jun 19, 2018 • edited Loading

Codecov Report

lbenet commented Jun 22, 2018

dpsanders commented Jun 22, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dpsanders commented Jun 22, 2018

lbenet commented Jun 23, 2018

coveralls commented Jun 23, 2018 • edited Loading

lbenet commented Jun 24, 2018

Choose a reason for hiding this comment

dpsanders commented Nov 26, 2018

lbenet commented Nov 26, 2018

codecov-io commented Jun 19, 2018 •

edited

Loading

coveralls commented Jun 23, 2018 •

edited

Loading