Delete deps/ directory
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be deleted since we now have CRlibm_jll. Happy to merge and help cleanup if someone can give me owner access on this org. |
|
@ViralBShah : I made you an owner of the org, thanks! |
|
Is |
|
Hmm, I didn't know about that. I got a Crlibm_jll today as part of Makie on my mac, so I assumed that was the case everywhere. At least it looks like the win32 binaries do get built: https://github.com/JuliaBinaryWrappers/CRlibm_jll.jl |
|
I think the win32 issue is this: #45. But at least doesn't have to do with the build. So deps can go... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any reason to keep the
deps/directory around? It's largish and unused