Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CRlibm_jll #41

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Use CRlibm_jll #41

merged 1 commit into from
Nov 27, 2020

Conversation

giordano
Copy link
Member

@giordano giordano commented Nov 27, 2020

Close #38

@giordano
Copy link
Member Author

@dpsanders you need to enable GitHub Actions...

@dpsanders
Copy link
Member

I think I just enabled GitHub actions. Do I need to do anything else?

Thanks very much for this, @giordano!

@giordano
Copy link
Member Author

Do I need to do anything else?

Since I'm moving all CI to GitHub Actions, if you don't want to see a red mark on all PRs and commits you should also disable Appveyor 🙂

@giordano
Copy link
Member Author

But GitHub Actions still don't start

@dpsanders
Copy link
Member

Do I need to "Allow all actions"?
Currently it's set to allow only local actions.

@giordano
Copy link
Member Author

Do I need to "Allow all actions"?

Yes 🙂

@dpsanders
Copy link
Member

OK, done, sorry!

@giordano giordano closed this Nov 27, 2020
@giordano giordano reopened this Nov 27, 2020
@giordano
Copy link
Member Author

Still nothing 😕

@dpsanders
Copy link
Member

Is it supposed to run already before the PR is merged?

@giordano
Copy link
Member Author

Yes

@giordano
Copy link
Member Author

Ok, I resuscitated Travis and Appveyor at least to be able to run the tests (provided that Travis works at all), but I suggest moving to GitHub Actions given the recent changes to Travis

@dpsanders
Copy link
Member

I'm very happy to move to GitHub actions if that's the recommended solution, provided it works...! Is it just that single "Allow all actions" setting that needs to be changed?

@giordano
Copy link
Member Author

Yes, but I'm honestly surprised that you had to do that at all since it should be on by default. Maybe you have some organisation-level settings blocking GitHub Actions?

@giordano giordano changed the title Use CRlibm_jll and move CI to GitHub Actions Use CRlibm_jll Nov 27, 2020
@dpsanders dpsanders merged commit be395be into JuliaIntervals:master Nov 27, 2020
@dpsanders
Copy link
Member

Great job, thanks a lot!

@giordano giordano deleted the mg/jll branch November 27, 2020 23:53
@dpsanders dpsanders mentioned this pull request Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants