Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for https://github.com/JuliaInterop/CxxWrap.jl/issues/419 #148

Merged
merged 3 commits into from
Apr 14, 2024

Conversation

barche
Copy link
Contributor

@barche barche commented Apr 1, 2024

https://github.com/JuliaInterop/CxxWrap.jl.git

@PraneethJain I had to remove the explicit return type on std::queue::front to fix JuliaInterop/CxxWrap.jl#419, but I'm not sure why the return type was specified in the first place?

@PraneethJain
Copy link
Contributor

PraneethJain commented Apr 2, 2024

I had included the explicit return types initially while referencing the diff for valarray, but on hindsight, it is not needed.

As for the tests, there seems to be some string parsing error due to the inclusion of the ` character. I'll look into it now.
https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#understanding-the-risk-of-script-injections
Anything surrounded by back ticks is executed as a bash command, which is the issue here. Apologies for the oversight.

@barche barche force-pushed the fix-queue-const branch 2 times, most recently from 33771ed to 77d7810 Compare April 2, 2024 05:10
@barche
Copy link
Contributor Author

barche commented Apr 2, 2024

Thanks for the reply, yes, I'm fixing the error by moving the body env var to the env block, no worries.

@barche barche force-pushed the fix-queue-const branch from 77d7810 to c45dd3b Compare April 2, 2024 05:22
@barche barche force-pushed the fix-queue-const branch from c45dd3b to 4851a9a Compare April 2, 2024 05:26
@barche barche merged commit 46ffb70 into main Apr 14, 2024
18 checks passed
@barche barche deleted the fix-queue-const branch April 14, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StdVector of pointer with CxxWrap 0.15
2 participants