Add StdFill #147
Merged
Add StdFill #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PraneethJain
force-pushed
the
main
branch
2 times, most recently
from
55daa12 to
2d368d4
Compare
PraneethJain
force-pushed
the
main
branch
2 times, most recently
from
3298cb2 to
4a56bcd
Compare
PraneethJain
force-pushed
the
main
branch
2 times, most recently
from
929c6c1 to
d12b454
Compare
|
Thanks for this, the only thing I would like changed is to put the linux and mac test back on Julia 1.6 instead of 1.7, and use the 1.7 only on Windows. That way we test on the 1.6 LTS release at least on some platforms. (both this PR and the CxxWrap PR, and assuming that I saw correctly that these should pass?). No remarks on the technical side, although it might be nice to have a common wrapper that adds methods such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/PraneethJain/CxxWrap.jl#main