New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array: use jl_array_ptr_set to avoid failed assertion on nightly #139

Merged

barche merged 1 commit into JuliaInterop:main from benlorenz:bl/array_set_fixup

Jan 11, 2024

Contributor

benlorenz commented Dec 20, 2023 •

edited

Loading

My fix from #137 unfortunately triggers an assertion in PkgEval (i.e. nightly built with assertions enabled):

Failed to precompile CxxWrap [1f15a43c-97ca-5a2a-ae31-89f07a497df4] to "/home/pkgeval/.julia/compiled/v1.11/CxxWrap/jl_g65kMF".
julia: /source/src/array.c:277: ijl_array_ptr_1d_push: Assertion `(((((jl_taggedvalue_t*)((char*)(a) - sizeof(jl_taggedvalue_t)))->header) & ~(uintptr_t)15)==(uintptr_t)(jl_array_any_type))' failed.

(The code does seem to work fine without assertions)

Switching to jl_array_ptr_set avoids that error and should also work across all supported julia versions.


          Array: use jl_array_ptr_set to avoid failed assertion on nightly

dbcf089

fixup JuliaInterop#137

barche merged commit a0b65ad into JuliaInterop:main

10 checks passed

Contributor

barche commented Jan 11, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet