Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slightly improve type instability and add a precompile statement #5

Merged
merged 2 commits into from
Oct 23, 2021
Merged

slightly improve type instability and add a precompile statement #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8be0108
slightly improve type instability and add a precompile statement
KristofferC Apr 27, 2021
b8f7249
simplified precompile
KristofferC Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/VersionParsing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ For example,
vparse(s::AbstractString) = vparse(String(s))

digits2num(s::AbstractString) = all(isdigit, s) ? parse(Int, s) : s
splitparts(s::AbstractString) = map(digits2num, filter!(!isempty, split(s, '.')))
splitparts(s::T) where {T <: AbstractString} = Union{Int, T}[digits2num(x) for x in filter!(!isempty, split(s, '.'))]

function vparse(s_::String)
s = replace(s_, r"^[^\d]*[^.\d](\.?\d)"=>s"\1") # strip non-numeric prefix
Expand Down Expand Up @@ -76,4 +76,6 @@ function vparse(s_::String)
end
end

precompile(Tuple{typeof(vparse), String})

end # module