RFC: add type dependency ordering #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce an ExprUnit type for grouping together expressions (e.g., enums), specifying dependencies, and maintaining wrapped/output status * Removed cache_wrapped (subsumed above) * empty_structs is now a Set * Type declarations, enums, and typealiases are stored in the common_buf, along with dependency information. * All enum Exprs are grouped together in the same ExprUnit * For other Exprs, there is one ExprUnit per Expr * Before outputting, the common_buf OrderedDict is dumped to an array with dependencies properly ordered. (Circular dependecies are implicitly detected, but remain.) * Function declarations are wrapped as before (in an array)
|
I haven't had a chance to test this, but otherwise LGTM if it's working for you. |
kmsquire
added a commit
that referenced
this pull request
Aug 12, 2014
RFC: add type dependency ordering
This was referenced Aug 12, 2014
melonedo
pushed a commit
to melonedo/Clang.jl
that referenced
this pull request
Jul 20, 2021
README: add GHA badge, remove Travis badge, remove AV badge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got around to adding dependency ordering for types (which has decreased my work in wrapping libav/ffmpeg significantly!). I'm not sure if or how this fits in with your other ideas (cf. Build EAR tool in #33), but if you haven't made much progress in that arena, this might be useful.
ExprUnittype for grouping together expressions(e.g., enums), specifying dependencies, and maintaining
wrapped/output status
cache_wrapped(subsumed above)empty_structsis now aSettypedeclarations,enums, andtypealiasesare stored in thecommon_buf, along with dependency information.Exprs are grouped together in the sameExprUnitExprs, there is oneExprUnitperExprcommon_bufOrderedDictis dumped to anarray with dependencies properly ordered. (Circular
dependecies are implicitly detected, but remain.)
Note: this subsumes #96, although those changes can be backed out. I find it useful having blank lines in the output, though.