-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate ColorizedArray in favor of MappedArray #927
Conversation
9bc0839
to
17ab0e1
Compare
Codecov Report
@@ Coverage Diff @@
## master #927 +/- ##
==========================================
+ Coverage 86.20% 86.24% +0.04%
==========================================
Files 9 9
Lines 1022 1025 +3
==========================================
+ Hits 881 884 +3
Misses 141 141
Continue to review full report at Codecov.
|
The one thing I worry about is ImageView. If I remember correctly, hover-over-pixel for a ColorizedArray displays the underlying value, not the mapped value. But we can do this if you think it's better. |
I see. It does give some visual aids, but this doesn't sound like what |
Not sure I really remember, but I think that is its main purpose. But you're right there are other ways to solve this. If this just seems too marginal we can do it, I was just thinking that there are many cases where array content and array labeling are two things that are useful to be able to link without losing track of either one. |
I get your point here. Given that you are probably the only user of this, I'll leave this to you to decide whether we should do it or not. BTW, I searched the whole GitHub and couldn't find any other place except Images.jl that contains |
MappedArray
provides a more generic version ofColorizedArray
so I believe it is good to not maintainColorizedArray
anymore.LazyArray
also provides similar operation;LazyArray(@~ @. I * indexed_img)
.closes JuliaImages/juliaimages.github.io#132