Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use master branch of deps in nightly test stage #806

Closed
wants to merge 2 commits into from
Closed

use master branch of deps in nightly test stage #806

wants to merge 2 commits into from

Conversation

johnnychen94
Copy link
Member

@johnnychen94 johnnychen94 commented May 9, 2019

CI updating work: #805

To make it work, you need:

SCRIPT_URL=https://gist.githubusercontent.com/johnnychen94/720900fd9e44395beaa0704770c91a36/raw/74f1a02f420a3ccd64b56cfc14111d170f559330/checkout_master.jl

  • retrigger the ci

Other related question:

can we set a daily/weekly Travis cron work on Images.jl#master? Or perhaps more aggressively disable allow_failures on nightly?

By doing this, whenever we want to tag a new release in submodules, we can check if Images.jl passes the nightly test stage, and fixes potential bugs if there are.

@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #806 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #806   +/-   ##
=======================================
  Coverage   58.98%   58.98%           
=======================================
  Files          10       10           
  Lines        1236     1236           
=======================================
  Hits          729      729           
  Misses        507      507

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ea7089...455bedb. Read the comment docs.

@johnnychen94
Copy link
Member Author

johnnychen94 commented May 16, 2019

Close this issue according to discussion in #805

@johnnychen94 johnnychen94 deleted the nightlyci branch May 16, 2019 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant