Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for julia 0.6 #32

Merged
merged 2 commits into from
Apr 10, 2017
Merged

Updates for julia 0.6 #32

merged 2 commits into from
Apr 10, 2017

Conversation

timholy
Copy link
Member

@timholy timholy commented Apr 1, 2017

This fixes deprecation warnings on julia 0.6. However, it doesn't pass, because the lbp test triggers an illegal instruction error:

$ julia-0.6 --check-bounds=yes
               _
   _       _ _(_)_     |  A fresh approach to technical computing
  (_)     | (_) (_)    |  Documentation: http://docs.julialang.org
   _ _   _| |_  __ _   |  Type "?help" for help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 0.6.0-pre.alpha.306 (2017-03-29 09:24 UTC)
 _/ |\__'_|_|_|\__'_|  |  Commit 1eb51b6* (3 days old master)
|__/                   |  x86_64-linux-gnu

julia> include("lbp.jl")
Test Summary: | Pass  Total
Original      |    8      8
Test Summary: | Pass  Total
Uniform       |    7      7
Test Summary: | Pass  Total
Modified      |    4      4
Test Summary:      | Pass  Total
Rotation Invariant |    9      9
Test Summary:   | Pass  Total
Direction Coded |    4      4
Test Summary: | Pass  Total
Multi Block   |    2      2

signal (4): Illegal instruction
while loading /home/tim/.julia/v0.6/ImageFeatures/test/lbp.jl, in expression starting on line 241
macro expansion at /home/tim/.julia/v0.6/ImageFeatures/test/lbp.jl:253 [inlined]
macro expansion at ./test.jl:853 [inlined]
anonymous at ./<missing> (unknown line)
jl_call_fptr_internal at /home/tim/src/julia-0.6/src/julia_internal.h:326 [inlined]
jl_call_method_internal at /home/tim/src/julia-0.6/src/julia_internal.h:345 [inlined]
jl_toplevel_eval_flex at /home/tim/src/julia-0.6/src/toplevel.c:589
jl_parse_eval_all at /home/tim/src/julia-0.6/src/ast.c:873
jl_load at /home/tim/src/julia-0.6/src/toplevel.c:616
include_from_node1 at ./loading.jl:539
unknown function (ip: 0x7fa076df22db)
jl_call_fptr_internal at /home/tim/src/julia-0.6/src/julia_internal.h:326 [inlined]
jl_call_method_internal at /home/tim/src/julia-0.6/src/julia_internal.h:345 [inlined]
jl_apply_generic at /home/tim/src/julia-0.6/src/gf.c:2234
include at ./sysimg.jl:14
unknown function (ip: 0x7fa076c948bb)
jl_call_fptr_internal at /home/tim/src/julia-0.6/src/julia_internal.h:326 [inlined]
jl_call_method_internal at /home/tim/src/julia-0.6/src/julia_internal.h:345 [inlined]
jl_apply_generic at /home/tim/src/julia-0.6/src/gf.c:2234
do_call at /home/tim/src/julia-0.6/src/interpreter.c:75
eval at /home/tim/src/julia-0.6/src/interpreter.c:242
jl_interpret_toplevel_expr at /home/tim/src/julia-0.6/src/interpreter.c:34
jl_toplevel_eval_flex at /home/tim/src/julia-0.6/src/toplevel.c:577
jl_toplevel_eval_in at /home/tim/src/julia-0.6/src/builtins.c:484
eval at ./boot.jl:235
eval at ./REPL.jl:3
unknown function (ip: 0x7f9e67900556)
jl_call_fptr_internal at /home/tim/src/julia-0.6/src/julia_internal.h:326 [inlined]
jl_call_method_internal at /home/tim/src/julia-0.6/src/julia_internal.h:345 [inlined]
jl_apply_generic at /home/tim/src/julia-0.6/src/gf.c:2234
eval_user_input at ./REPL.jl:66
unknown function (ip: 0x7f9e67900f96)
jl_call_fptr_internal at /home/tim/src/julia-0.6/src/julia_internal.h:326 [inlined]
jl_call_method_internal at /home/tim/src/julia-0.6/src/julia_internal.h:345 [inlined]
jl_apply_generic at /home/tim/src/julia-0.6/src/gf.c:2234
macro expansion at ./REPL.jl:97 [inlined]
#1 at ./event.jl:73
unknown function (ip: 0x7f9e678fda7f)
jl_call_fptr_internal at /home/tim/src/julia-0.6/src/julia_internal.h:326 [inlined]
jl_call_method_internal at /home/tim/src/julia-0.6/src/julia_internal.h:345 [inlined]
jl_apply_generic at /home/tim/src/julia-0.6/src/gf.c:2234
jl_apply at /home/tim/src/julia-0.6/src/julia.h:1416 [inlined]
start_task at /home/tim/src/julia-0.6/src/task.c:261
unknown function (ip: 0xffffffffffffffff)
Allocations: 22160164 (Pool: 22158164; Big: 2000); GC: 27
/home/tim/bin/julia-0.6: line 2: 32070 Illegal instruction     (core dumped) ~/src/julia-0.6/julia "$@"

Interestingly, if you comment out the @testset "Descriptor" begin and complementary end, then there's no error.

This is clearly a julia bug; I don't yet have a simple reproducer, which is why I haven't reported it yet.

@timholy
Copy link
Member Author

timholy commented Apr 1, 2017

JuliaLang/julia#21250

@timholy timholy merged commit 13e34f3 into master Apr 10, 2017
@timholy timholy deleted the teh/0.6 branch April 10, 2017 15:14
@timholy
Copy link
Member Author

timholy commented Apr 10, 2017

The tests on AppVeyor in particular were taking a long time due to deprecations. Should be better now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant