Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Julia 1.0, alphabetize [compat] #194

Merged
merged 4 commits into from
Jul 21, 2023
Merged

Drop Julia 1.0, alphabetize [compat] #194

merged 4 commits into from
Jul 21, 2023

Conversation

timholy
Copy link
Member

@timholy timholy commented Jul 21, 2023

Makes Aqua happy

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -4.23 ⚠️

Comparison is base (0046ec7) 75.50% compared to head (55d6d5c) 71.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
- Coverage   75.50%   71.28%   -4.23%     
==========================================
  Files          10       10              
  Lines         592      592              
==========================================
- Hits          447      422      -25     
- Misses        145      170      +25     
Impacted Files Coverage Δ
src/precompile.jl 94.18% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timholy timholy closed this Jul 21, 2023
@timholy timholy reopened this Jul 21, 2023
@timholy
Copy link
Member Author

timholy commented Jul 21, 2023

OK, it's worse than I thought. This is only about tests, but it can't even install the test dependencies on Julia 1.0.

I really regret not making Julia 1.6 the minimum for this release. Let's see if General allows us to register 0.10.1 while dropping Julia 1.0 support.

@timholy timholy merged commit 145ffd4 into master Jul 21, 2023
@timholy timholy deleted the teh/aqua branch July 21, 2023 14:27
@timholy
Copy link
Member Author

timholy commented Jul 21, 2023

What do you know...it's accepting it. Somehow I thought we had to bump the minor version when dropping support for older Julia versions, but maybe that applies only post-1.x packages (for which a minor bump is not breaking).

@timholy timholy changed the title Alphabetize [compat] Drop Julia 1.0, alphabetize [compat] Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant