Require CVS 0.10 #192
Merged
Require CVS 0.10 #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets the stage for the entire JuliaImages ecosystem switching to ColorVectorSpace 0.10. We can also anticipate the removal of ColorVectorSpace.Future.abs2 internally, so the switch to CVS 0.11 won't require a breaking change here or elsewhere.
|
I'll be sure to rerun CI once Sixel and ReferenceTests have their ImageCore [compat] updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the stage for the entire JuliaImages ecosystem switching
to ColorVectorSpace 0.10. We can also anticipate the removal
of ColorVectorSpace.Future.abs2 internally, so the switch to
CVS 0.11 won't require a breaking change here or elsewhere.
This is going to be an absolute mess on CI: our test
[extras]include Sixel (via ImageInTerminal) and ReferenceTests, both of which in turn depend on ImageCore. Thus even though the package dependencies are acyclic, our test dependencies are cyclic. So it's guaranteed that CI will fail here until those packages have their dependencies bumped.I've removed ImageMagick as a test dependency since it doesn't seem to be used.