Support zeroarray for heterogeneous axes #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `ZeroArrayPromise` required homogeneous axes, this supports promotion prior to construction. The test requires BlockArrays 0.16.17 (specifically JuliaArrays/BlockArrays.jl#213) but it's not a dependency of the package, so let's just trust in the lack of conflicts.
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
+ Coverage 62.60% 62.67% +0.06%
==========================================
Files 10 10
Lines 583 584 +1
==========================================
+ Hits 365 366 +1
Misses 218 218
Continue to review full report at Codecov.
|
|
Let's try it now that BlockArrays 0.16.18 is out. |
johnnychen94
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
ZeroArrayPromiserequired homogeneous axes,this supports promotion prior to construction.
The test requires BlockArrays 0.16.
1718 (specificallyJuliaArrays/BlockArrays.jl#213)
but it's not a dependency of the package, so let's just
trust in the lack of conflicts.