Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict clamp01 to gray & RGB #181

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Restrict clamp01 to gray & RGB #181

merged 1 commit into from
Jul 20, 2023

Conversation

timholy
Copy link
Member

@timholy timholy commented May 13, 2022

The 0-to-1 colorscale does not have meaning for colors like HSV,
so supporting arbitrary colorants seems wrong.

I noticed this while working on JuliaImages/MultiChannelColors.jl#4. We might not want to merge this until we decide to make a push for the next breaking release.

The 0-to-1 colorscale does not have meaning for colors like HSV,
so supporting arbitrary colorants seems wrong.
@timholy
Copy link
Member Author

timholy commented May 14, 2022

Have you noticed the CI failure previously? It happens on master too. I haven't delved deeply to see what changed it, but from a quick debug it has to do with using the typeinfo in display, i.e., https://github.com/JuliaGraphics/ColorTypes.jl/blob/b8ed378531f1445ed2402a00d49ecbf64ce5a0fc/src/show.jl#L11-L18. What puzzles me is that this isn't new. Maybe there was some dependency change?

I think the new way of printing is nicer so wondering if we should change the docstring, but it would be nice to know what dependency changed so we can add it to the [compat].

@johnnychen94
Copy link
Member

johnnychen94 commented May 14, 2022

It's because you've made a ColorTypes release v0.11.1 4 days ago and shipped every commit before that JuliaGraphics/ColorTypes.jl@b8ed378#comments 😆

I guess @kimikage planned a bigger release v0.12 or so. BTW, I'm wondering what happened to him; haven't seen him active for quite a long time. Hope he's still okay.

@timholy
Copy link
Member Author

timholy commented May 15, 2022

Oh shoot. I didn't check how much was on master, big mistake.

I will try to fix this. I think the best plan is to fork a release 0.11 branch, backport my recent commit, and release 0.11.2. Reasonable?

@timholy timholy closed this May 15, 2022
@timholy timholy reopened this May 15, 2022
@codecov
Copy link

codecov bot commented May 15, 2022

Codecov Report

Merging #181 (ad9bcc8) into master (9e64fec) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #181   +/-   ##
=======================================
  Coverage   62.60%   62.60%           
=======================================
  Files          10       10           
  Lines         583      583           
=======================================
  Hits          365      365           
  Misses        218      218           
Impacted Files Coverage Δ
src/map.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e64fec...ad9bcc8. Read the comment docs.

@timholy timholy merged commit 0046ec7 into master Jul 20, 2023
@timholy timholy deleted the teh/clamp branch July 20, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants