Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] fix the Vararg in UnionAll depwarn #167

Merged
merged 2 commits into from
Jun 26, 2021
Merged

[patch] fix the Vararg in UnionAll depwarn #167

merged 2 commits into from
Jun 26, 2021

Conversation

johnnychen94
Copy link
Member

closes #166

@tomyun Since this is only a depwarn on 1.7-DEV I'm not going to rush to make a new release.

@codecov
Copy link

codecov bot commented Apr 25, 2021

Codecov Report

Merging #167 (436fc72) into master (4fb1321) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   62.56%   62.56%           
=======================================
  Files          10       10           
  Lines         561      561           
=======================================
  Hits          351      351           
  Misses        210      210           
Impacted Files Coverage Δ
src/colorchannels.jl 48.93% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fb1321...436fc72. Read the comment docs.

@tomyun
Copy link

tomyun commented Jun 25, 2021

As Julia 1.7.0 beta has been around for a while and rc is perhaps coming soon, can we get this rolled out to make CI working again?

@johnnychen94 johnnychen94 merged commit e402ffe into master Jun 26, 2021
@johnnychen94 johnnychen94 deleted the jc/vararg branch June 26, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vararg-UnionAll deprecation with Julia 1.7-DEV
2 participants