Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sample code to latest Makie API fix #354 #355

Merged
merged 11 commits into from
Jun 1, 2022
Merged

update sample code to latest Makie API fix #354 #355

merged 11 commits into from
Jun 1, 2022

Conversation

FelipeLema
Copy link
Contributor

show_axis & scale_plot no longer supported

fixes #354

`show_axis` & `scale_plot` no longer supported
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #355 (bcdd758) into master (294f94f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #355   +/-   ##
=======================================
  Coverage   78.61%   78.61%           
=======================================
  Files          10       10           
  Lines        1253     1253           
=======================================
  Hits          985      985           
  Misses        268      268           
Impacted Files Coverage Δ
src/VideoIO.jl 18.18% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 294f94f...bcdd758. Read the comment docs.

@IanButterworth
Copy link
Member

@FelipeLema I hope you don't mind, I pushed some more fixes for the docs and viewcam.

Would you mind testing whether viewcam() works for you? On MacOS for me it loads and grabs images but nothing shows in the Makie window.

@FelipeLema
Copy link
Contributor Author

it shows a blank screen to me too. Let me have a go at it

@FelipeLema
Copy link
Contributor Author

It properly shows a x-flipped image from my webcam (mimics a mirror)

there are some other details (provided width & height is ignored), but I guess we can go with this one in the meantime

shoutouts to macOS' GateKeeper for quietly blocking me on this one for so long

@FelipeLema
Copy link
Contributor Author

I dunno what's up with format linter, but this is ready to go

@IanButterworth
Copy link
Member

Thanks I'll test locally and fix the formatter (this is the first PR after I added that, so it's good to fix it)

@IanButterworth IanButterworth merged commit 6b99317 into JuliaIO:master Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Video Playback" code is not working with latest Makie
2 participants