-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update sample code to latest Makie API fix #354 #355
update sample code to latest Makie API fix #354 #355
Conversation
`show_axis` & `scale_plot` no longer supported
Codecov Report
@@ Coverage Diff @@
## master #355 +/- ##
=======================================
Coverage 78.61% 78.61%
=======================================
Files 10 10
Lines 1253 1253
=======================================
Hits 985 985
Misses 268 268
Continue to review full report at Codecov.
|
@FelipeLema I hope you don't mind, I pushed some more fixes for the docs and Would you mind testing whether |
it shows a blank screen to me too. Let me have a go at it |
"Makie has no flip functionality?" see https://discourse.julialang.org/t/different-image-orientation-in-images-vs-makie/42288
….jl into makie_code_update_354
It properly shows a x-flipped image from my webcam (mimics a mirror) there are some other details (provided width & height is ignored), but I guess we can go with this one in the meantime shoutouts to macOS' GateKeeper for quietly blocking me on this one for so long |
I dunno what's up with format linter, but this is ready to go |
Thanks I'll test locally and fix the formatter (this is the first PR after I added that, so it's good to fix it) |
show_axis
&scale_plot
no longer supportedfixes #354