Close file during path-based get_duration get_start_time get_time_duration #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
==========================================
+ Coverage 73.94% 74.31% +0.37%
==========================================
Files 14 14
Lines 614 623 +9
==========================================
+ Hits 454 463 +9
Misses 160 160
Continue to review full report at Codecov.
|
|
Can confirm that this fixes my issue! Feel free to merge! Thank you for the help @ianshmean 😄 I forked and checked out to this branch and now all my tests pass. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Candidate fix for #262
@TheCedarPrince: If these tests pass, can you give this a go